IS-55.00 Regenerated Schema #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSP_PIMS S55.00 Sprint 55 2023-May-26 - Added tables: - PIMS_ACQUISITION_OWNER_REP - PIMS_ACQUISITION_OWNER_REP_HIST - PIMS_INTEREST_HOLDER - PIMS_INTEREST_HOLDER_HIST - PIMS_INTEREST_HOLDER_INTEREST_TYPE - PIMS_INTHLDR_PROP_INTEREST - PIMS_INTHLDR_PROP_INTEREST_HIST - Altered tables: - PIMS_ACQ_CHKLST_ITEM_TYPE - PIMS_ACQ_CHKLST_SECTION_TYPE - PIMS_ACQ_PAYEE_CHEQUE - PIMS_ACQ_PAYEE_CHEQUE_HIST - PIMS_ACQUISITION_PAYEE - PIMS_ACQUISITION_PAYEE_HIST - Added seed scripts: - 130_DML_PIMS_INTEREST_HOLDER_INTEREST_TYPE.sql - Altered seed scripts: - 120_DML_PIMS_ACQ_CHKLST_SECTION_TYPE.sql - 121_DML_PIMS_ACQ_CHKLST_ITEM_TYPE.sql - Requires additional metadata to meet standards
Added the conditional creation of spatial indices in PIMS_PROPERTY - 005_PSP_PIMS_PROPERTY_SPATIAL_IDX.sql
003_Delete_DynamicConstraint.sql
Added foreign key between Acquisition File and Interest Holder
Added IS_PAYMENT_IN_TRUST to PIMS_ACQ_PAYEE_CHEQUE
Regenerated to address spurious errors. PSP_PIMS S55.00 Sprint 55 2023-May-26 - Added tables: - PIMS_ACQUISITION_OWNER_REP - PIMS_ACQUISITION_OWNER_REP_HIST - PIMS_INTEREST_HOLDER - PIMS_INTEREST_HOLDER_HIST - PIMS_INTEREST_HOLDER_INTEREST_TYPE - PIMS_INTHLDR_PROP_INTEREST - PIMS_INTHLDR_PROP_INTEREST_HIST - Altered tables: - PIMS_ACQ_CHKLST_ITEM_TYPE - PIMS_ACQ_CHKLST_SECTION_TYPE - PIMS_ACQ_PAYEE_CHEQUE - PIMS_ACQ_PAYEE_CHEQUE_HIST - PIMS_ACQUISITION_PAYEE - PIMS_ACQUISITION_PAYEE_HIST - Added seed scripts: - 130_DML_PIMS_INTEREST_HOLDER_INTEREST_TYPE.sql - Altered seed scripts: - 120_DML_PIMS_ACQ_CHKLST_SECTION_TYPE.sql - 121_DML_PIMS_ACQ_CHKLST_ITEM_TYPE.sql - Requires additional metadata to meet standards
dfilteau
requested review from
devinleighsmith,
asanchezr,
FuriousLlama,
stairaku,
PryancaJSharma,
eddherrera and
buddy326
as code owners
|
✅ No secrets were detected in the code. |
devinleighsmith
requested changes
May 31, 2023
There was a problem hiding this comment.
@dfilteau this does not fix the problems with the IS55 alter up/build.
ie: this is still present:
[PIMS_INTHLDR_PROP_INTEREST_ID] varchar(40) NOT NULL CONSTRAINT [IHPRIN_PIMS_INTHLDR_PROP_INTEREST_ID_DEF] DEFAULT ('NEXT VALUE FOR [PIMS_INTHLDR_PROP_INTEREST_ID_SEQ]'),
Comment on lines
67
to
68
| PRINT N'Create sequence dbo.PIMS_INTHLDR_PROP_INTEREST_ID_SEQ' | ||
| GO |
There was a problem hiding this comment.
I think the problem is with the table definition:
CREATE TABLE [dbo].[PIMS_INTHLDR_PROP_INTEREST] (
[PIMS_INTHLDR_PROP_INTEREST_ID] varchar(40) NOT NULL CONSTRAINT [IHPRIN_PIMS_INTHLDR_PROP_INTEREST_ID_DEF] DEFAULT ('NEXT VALUE FOR [PIMS_INTHLDR_PROP_INTEREST_ID_SEQ]'),
```
VARCHAR(40) changed to BIGINT
@devinleighsmith, @FuriousLlama, fixed now. |
|
✅ No secrets were detected in the code. |
devinleighsmith
approved these changes
May 31, 2023
FuriousLlama
approved these changes
May 31, 2023
devinleighsmith
pushed a commit
to devinleighsmith/PSP
that referenced
this pull request
Jun 1, 2023
* IS-55.00 Database Schema PSP_PIMS S55.00 Sprint 55 2023-May-26 - Added tables: - PIMS_ACQUISITION_OWNER_REP - PIMS_ACQUISITION_OWNER_REP_HIST - PIMS_INTEREST_HOLDER - PIMS_INTEREST_HOLDER_HIST - PIMS_INTEREST_HOLDER_INTEREST_TYPE - PIMS_INTHLDR_PROP_INTEREST - PIMS_INTHLDR_PROP_INTEREST_HIST - Altered tables: - PIMS_ACQ_CHKLST_ITEM_TYPE - PIMS_ACQ_CHKLST_SECTION_TYPE - PIMS_ACQ_PAYEE_CHEQUE - PIMS_ACQ_PAYEE_CHEQUE_HIST - PIMS_ACQUISITION_PAYEE - PIMS_ACQUISITION_PAYEE_HIST - Added seed scripts: - 130_DML_PIMS_INTEREST_HOLDER_INTEREST_TYPE.sql - Altered seed scripts: - 120_DML_PIMS_ACQ_CHKLST_SECTION_TYPE.sql - 121_DML_PIMS_ACQ_CHKLST_ITEM_TYPE.sql - Requires additional metadata to meet standards * Added Spatial Indicies Added the conditional creation of spatial indices in PIMS_PROPERTY - 005_PSP_PIMS_PROPERTY_SPATIAL_IDX.sql * Added Deletion of Dynamic Constraints to Alter Up 003_Delete_DynamicConstraint.sql * Added Foreign Key Added foreign key between Acquisition File and Interest Holder * Dropped FK Script in Alter Down * Added Payment in Trust Added IS_PAYMENT_IN_TRUST to PIMS_ACQ_PAYEE_CHEQUE * IS-55.00 Regenerated Schema Regenerated to address spurious errors. PSP_PIMS S55.00 Sprint 55 2023-May-26 - Added tables: - PIMS_ACQUISITION_OWNER_REP - PIMS_ACQUISITION_OWNER_REP_HIST - PIMS_INTEREST_HOLDER - PIMS_INTEREST_HOLDER_HIST - PIMS_INTEREST_HOLDER_INTEREST_TYPE - PIMS_INTHLDR_PROP_INTEREST - PIMS_INTHLDR_PROP_INTEREST_HIST - Altered tables: - PIMS_ACQ_CHKLST_ITEM_TYPE - PIMS_ACQ_CHKLST_SECTION_TYPE - PIMS_ACQ_PAYEE_CHEQUE - PIMS_ACQ_PAYEE_CHEQUE_HIST - PIMS_ACQUISITION_PAYEE - PIMS_ACQUISITION_PAYEE_HIST - Added seed scripts: - 130_DML_PIMS_INTEREST_HOLDER_INTEREST_TYPE.sql - Altered seed scripts: - 120_DML_PIMS_ACQ_CHKLST_SECTION_TYPE.sql - 121_DML_PIMS_ACQ_CHKLST_ITEM_TYPE.sql - Requires additional metadata to meet standards * Fixed PIMS_INTHLDR_PROP_INTEREST VARCHAR(40) changed to BIGINT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerated to address spurious errors.
PSP_PIMS S55.00 Sprint 55 2023-May-26